Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Varun Mishra
Varun Mishra
4,180 Points
Posted by Varun Mishra
Varun Mishra
4,180 Points

It gives me an error message "It looks like Task 1 is no longer passing" even though I am in task 2.

It gives me an error message "It looks like Task 1 is no longer passing" even though I am in task 2.

js/app.js 
let navigationLinks = document.querySelector('nav').querySelectorAll('a');
let galleryLinks = document.getElementsById('gallery');
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>
James Kenney
James Kenney
13,910 Points

The question asks to select all links with the id of gallery. You only put "gallery" into your code instead of "#gallery a".

The correct code in the js/app.js sould be...

let navigationLinks = document.querySelectorAll('nav ul li a');
let galleryLinks = document.querySelectorAll('#gallery a');
let footerImages;

2 Answers

Steven Parker
Steven Parker
231,271 Points
Steven Parker
Steven Parker
231,271 Points

Any syntax error will invalidate the whole script and cause the re-validations to fail. In this case, the cuase is calling the non-existent method "getElementsById". There's an actual method named "getElementById" (singular), but it's probably not the one you want to use in this case anyway.

Also, did you know that you can make "document.querySelector('nav').querySelectorAll('a');" more compact by writing "document.querySelectorAll('nav a');"?

Varun Mishra
Varun Mishra
4,180 Points
Varun Mishra
Varun Mishra
4,180 Points

document.querySelector(); finds and selects the first element, wouldn't document.querySelectorAll('nav a'); select all elements with nav and a?

Steven Parker
Steven Parker
231,271 Points
Steven Parker
Steven Parker
231,271 Points

You're right that there is a slight difference. Chaining the methods gives you the "links in the first nav element" where the single method with the descendant selector gives you the "links in any nav element". But they are equivalent for this document because it has only one nav element.

Varun Mishra
Varun Mishra
4,180 Points
Varun Mishra
Varun Mishra
4,180 Points

Cool thanks! just wanted to make sure!