Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Nathaniel Bennett
seal-mask
.a{fill-rule:evenodd;}techdegree
Nathaniel Bennett
Full Stack JavaScript Techdegree Student 15,756 Points
Posted by Nathaniel Bennett
.a{fill-rule:evenodd;}techdegree
Nathaniel Bennett
Full Stack JavaScript Techdegree Student 15,756 Points

Bummer: Your implementation is off. Try again.

can't figure out why replace isn't the correct implementation

index.js 
var utilities = require("./utilities");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
utilities.js 
function merge(content, values) {
    content = content.replace("%first_name%", values.first_name);
    return content;
}


module.exports.merge = merge;

1 Answer

Steven Parker
Steven Parker
243,318 Points
Steven Parker
Steven Parker
243,318 Points

The instructions read "You should be able to pass in a string with placeholders with percent signs (%) surrounding them.."

The actual string with placeholders will be the first argument, and should not be hard-coded into the method. The sample call using "%first_name%" is just an example and the actual string to replace might be anything.

Nathaniel Bennett
seal-mask
.a{fill-rule:evenodd;}techdegree
Nathaniel Bennett
Full Stack JavaScript Techdegree Student 15,756 Points
Nathaniel Bennett
.a{fill-rule:evenodd;}techdegree
Nathaniel Bennett
Full Stack JavaScript Techdegree Student 15,756 Points

I'm still not understanding how to replace "%first_name%" all the information I can find on replacing text says I've done it correctly but treehouse is still not accepting it.

Steven Parker
Steven Parker
243,318 Points
Steven Parker
Steven Parker
243,318 Points

Yes, your code will replace "%first_name%", but that is only an example of what it needs to do. Your code needs to handle the replacement of any string bounded by percent signs, with possibly more than one, based on the arguments given to it.

So another example it should be able to handle:

values.item = "Pillow";
values.color = "Blue";

var template = "You have chosen a %color% %item%.";

var mergedContent = utilities.merge(template, values);