Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Nicci Boots
Nicci Boots
3,459 Points
Posted by Nicci Boots
Nicci Boots
3,459 Points

Call the function and display the results in an alert dialog

I'm not sure why this isn't working - does anyone see something wrong in my code?

script.js 
function max(six, eight){
  if (six > eight){
    return six;
  } else {
    return eight;
  }
}
alert(max(six,eight));

3 Answers

Ricardo Vargas
Ricardo Vargas
3,583 Points
Ricardo Vargas
Ricardo Vargas
3,583 Points

it is because you are using variables not defined instead of integers(numbers), javacript dont know what six is (without quotes, if it had quotes it would be a string).

Also, the paramaters of your function should be named something like number1 and number2, once the function is defined, you can put any number you want when calling the function.

change the name of the numbers for numbers. 

function max(number1, number2){
  if (number1 > number2){
    return number1;
  } else {
    return number2;
  }
}
alert(max( 6 , 8 ));

Let me know if I was clear.

Devin Scheu
Devin Scheu
66,191 Points
Devin Scheu
Devin Scheu
66,191 Points

Your answer should look like this :):

function max(num1, num2) {
  if (num1 > num2) {
    return num1;
  }
  if (num1 < num2) {
    return num2;
  }
}
Nicci Boots
Nicci Boots
3,459 Points
Nicci Boots
Nicci Boots
3,459 Points

You guys are the best! It totally makes sense now - thanks so much! :)