Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Aaron HARPT
Aaron HARPT
19,845 Points
Posted by Aaron HARPT
Aaron HARPT
19,845 Points

code challenge problem

I am having trouble with the following code challenge.

Create a new function named max() which accepts two numbers as arguments. The function should return the larger of the two numbers. You'll need to use a conditional statement to test the 2 numbers to see which is the larger of the two.

script.js 
function max(num_1, num_2) {
  var number_1 = 100;
  var number_2 = 50;
  if (number_1 > number_2 ) {
  document.write("number_1");
  } else {
   document.write("number_2");
  }
} 
max();

2 Answers

Chris Shaw
Chris Shaw
26,676 Points
Chris Shaw
Chris Shaw
26,676 Points

Hi Aaron,

This challenge only requires you to compare both parameters and return the number in which is considered higher using an IF statement which you've already done.

function max(a, b) {
  if (a > b) {
    return a;
  } else {
    return b;
  }
}

So in this example I've change the parameter names to a and b which is good practice when creating functions such as this as it's referred to a term called A/B testing.

Happy coding.

Ryan Field
PLUS
Ryan Field
Courses Plus Student 21,242 Points
Ryan Field
Ryan Field
Courses Plus Student 21,242 Points

You need to switch out the 100 and 50 with the variables that you have declared in the function (num_1 and num_2). Then, to call the function, you'll need to supply two numbers like this:

max(22,49);

which should write the larger of the two to the page.

In the case that you want to use a prompt() call to get numbers from user input, though, you'll need to call the parseInt() function on them like this:

var number_1 = parseInt(num_1);
var number_2 = parseInt(num_2);

as prompt() inputs will return a string and not a number.