Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

logan neher
logan neher
6,949 Points
Posted by logan neher
logan neher
6,949 Points

Creating a function: What is wrong with my code?

Create a new function named max which accepts two numbers as arguments (you can name the arguments, whatever you would like). The function should return the larger of the two numbers.

HINT: You'll need to use a conditional statement to test the 2 parameters to see which is the larger of the two.

script.js 
function max(first, second) {
  if (first > second
    return first;
} else {
  return second;
}

2 Answers

Stuart Wright
Stuart Wright
41,119 Points
Stuart Wright
Stuart Wright
41,119 Points

You just need to be careful with your curly braces and parentheses. You're missing a closing ) and an opening { after your if statement, and then you're also missing a closing } to close your function. Indentation can help to make these more obvious:

function max(first, second) {
    if (first > second) {
        return first;
    } else {
        return second;
    }
}
Lawrence Babay
Lawrence Babay
6,941 Points
Lawrence Babay
Lawrence Babay
6,941 Points

Also you can use Math.max() in this challenge to eliminate the conditional statements.

Lawrence Babay
Lawrence Babay
6,941 Points

function max(a, b) { if (a > b) { return a; } else { return b; } }

alert(Math.random(max(3,2)));

function max(a, b) { return Math.max(a, b); }

alert(Math.random(max(3,2)));