Feedback on my programs (Averager).

Question

I am doing the 4 side projects that were proposed at the end of C# Basics. I am looking for any type of feedback from the community: How to follow the conventions, improve readability, optimize the program, etc..

This is the first suggestion, the averager. The user enters as many numbers as he wants and when he types "done", the program average them all. In this program I had to declare 3 of the 4 variables at the top of the code, despite my best efforts against it, and I was wondering if it was possible to do otherwise?

using System;

class Averager
{
    static void Main()
    {
      var number = 0.0;
      var total = 0.0;
      var totalNumber = 0;
      Console.Write("Enter any amount of numbers you like or type \"done\" to average them: \n");
      while (true)
      {
        try
        {
          //Repeatedly prompt the user for numbers
          var input = Console.ReadLine();

          if (input.ToLower() != "done")
          {
            //Add all numbers together
            //Keep track of the total number of numbers

            number = double.Parse(input);
            total += number;
            totalNumber += 1;
            continue;
          }
          else
          {
            //When the user types "done", print the average

            number = total / totalNumber;
            Console.Write("Your average is " + number + "\n");
            break;
          }
        }
        catch ( Exception ex )
        {
          if (ex is FormatException ||
              ex is OverflowException)
          {
          Console.WriteLine("That is not valid input");
          continue;
          }
          throw;
        }
      }
    }
}

Answer 1 · 2017-07-06T14:31:35Z

July 6, 2017 2:31pm

I think your code looks good.

Here is some feedback to help you out:

Add a namespace (it is good to get into this habit early on).
Add multiple catch statements (instead of checking the exception type).
Use the increment operator to increase the variable totalNumber (totalNumber++).

I cannot think of a way to avoid the variables at the top of your code (this is the way that I approached the problem as well). One way to avoid this would be to use a couple of functions. The variables would still need to be declared at the top of one of those functions though.

Welcome to the Treehouse Community

Looking to learn something new?

Samuel Savaria

Samuel Savaria

Feedback on my programs (Averager).

1 Answer

Chris Stowe

Chris Stowe