Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Luis Paulino
PLUS
Luis Paulino
Courses Plus Student 1,779 Points

How to set number?

I tried setting actual number for the first line, but it wouldn't pass. When I get to exercise 2 now it needs actual numbers. lol

script.js
function max(five,eight){
  return eight; }
alert(max('five','eight'));

2 Answers

Carlos Martinez
Carlos Martinez
10,660 Points

You need to add the numerical values. Like 5 and 8. No quotation marks.

Edit: Although, I don't think your code will run, even if you do that.

Alex Lewis
Alex Lewis
15,619 Points

You need to test to see which number is larger in order to make this reusable.

Something like this checks to see which number is larger and returns it

function max(numOne, numTwo){
 return numOne > numTwo ?  numOne :  numTwo;
}

(This ternary operation basically says "is numOne larger than numTwo? If it is, return numOne, if not return numTwo)

While your answer does return the larger number, it doesn't work as intended if you switch around the numbers you pass in.