I cannot seem to get the right code for this challange

Question

I am not positive about this conditional statement, it seems that this particular problem was not addressed in the videos or my syntax is lacking, I have tried different variations using parseInt.   please help
```script.js
function max (num1, num2) {
 if {(num1) > (num2) alert (num1);}
   else {alert(num2);}
         return max;}
  console.log max(20, 30);
```

Steven Parker · Accepted Answer

:point_right: You have an undefined variable, some misplaced braces and missing parentheses.
You also have a bunch of unnecessary parentheses and alert statements.  The function name "max" has no special meaning inside the function, and in particular cannot be used as a variable (but you could declare one with that name if you wanted).
A more condensed and corrected function might look like this:
cs
function max(num1, num2) {
    if (num1 > num2)  // the conditional expression must be in parentheses
        return num1;  // a single statement needs no braces
    return num2;      // ELSE is not needed when the IF does a RETURN
}

If you'd like to review, conditional statements were introduced in the previous module in this video (https://teamtreehouse.com/library/javascript-basics/making-decisions-with-conditional-statements/introducing-conditional-statements).

Lance Volk · Answer

Thanks Steven, I thought that I was over thinking the problem, the two returns kind of threw me, but it ended up being quite logical, I will review some of the videos to see what I missed.
Thanks again
Lance

Welcome to the Treehouse Community

Looking to learn something new?

Lance Volk

Lance Volk

I cannot seem to get the right code for this challange

2 Answers

Steven Parker

Steven Parker

You have an undefined variable, some misplaced braces and missing parentheses.

Lance Volk

Lance Volk