Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Ravon Henson
Ravon Henson
4,038 Points
Posted by Ravon Henson
Ravon Henson
4,038 Points

I cant seem to get this

ive been trying and i just cant get it

script.js 
function max(meme, pepe) {
  if (meme > pepe) {
  }return parseInt(meme);
   else if (pepe > meme) {
     return parseInt(pepe);
   } else {
     return "wtf did you do";
}
max(1, 2)
Ashish Mehra
Ashish Mehra
471 Points

Ravon Henson , Your forget to close function with curly brace and colon at the time of call.

David Bath
David Bath
25,940 Points
David Bath
David Bath
25,940 Points

Your return value statement should be between the braces, not after them. And I don't think you need to parseInt the return value. And as Ashish mentioned, you're missing a curly brace.

2 Answers

Stephan Olsen
Stephan Olsen
6,650 Points
Stephan Olsen
Stephan Olsen
6,650 Points

The first return statement is outside of the curly brackets, and you're not closing the function.

Ken jones
Ken jones
5,394 Points
Ken jones
Ken jones
5,394 Points

You don't need to use parseInt here.

Also, using a second conditional is superfluous in this statement. 

function max(meme, pepe) {
  if (meme > pepe) {
    return meme;
  } else { // we would only be this far in the code if meme < pepe so there is no need to test for it
    return pepe;
  } 
}

Alternatively, you can do away with the if else statement entirely and do this...

function max(meme, pepe) {
  return Math.max(meme, pepe);
}