Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Jason Brown
Jason Brown
9,626 Points
Posted by Jason Brown
Jason Brown
9,626 Points

I really don't get what I'm doing wrong here ...

Seems basic enough? Any help would be appreciated. Thanks!

script.js 
function max(a,b) {
  var output;
  if (a > b) {
    output = "a";
  } else {
    output = "b";
  }
  return output;
}
max(2,3);

1 Answer

andren
andren
28,558 Points
andren
andren
28,558 Points

The problem is that you surround a and b in quotes when you assign them. Quotes are used to create strings, not to reference variables. If you remove the quotes surrounding them then your code will work.

Though it's also worth noting that your code is more verbose than it need to be. You don't need to create a output variable. You can just return the value directly within the if/else statement like this:

function max(a,b) {
  if (a > b) {
    return a;
  } else {
    return b;
  }
}
Jason Brown
Jason Brown
9,626 Points
Jason Brown
Jason Brown
9,626 Points

It worked! Thanks! Much appreciated.