Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Sondre Fjellving
Sondre Fjellving
4,700 Points
Posted by Sondre Fjellving
Sondre Fjellving
4,700 Points

I'm not able to assign the links inside the nav element (html) to: let navigationLinks; using querySelectorAll

I made sure I added a class to all of the links inside the nav element. But I still get error message where it says that I only managed to assign 1 out of 3 links. What to do?

js/app.js 
let navigationLinks = document.querySelectorAll(".selected");
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html" class="selected">About</a></li>
          <li><a href="contact.html" class="selected">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

1 Answer

Steven Parker
Steven Parker
231,271 Points
Steven Parker
Steven Parker
231,271 Points

For this challenge, all work should be done in JavaScript. The HTML file is provided for inspection only, you should not make any changes to it.

So you'll need to use a different selector to target the links that are inside the "nav" element.

Sondre Fjellving
Sondre Fjellving
4,700 Points
Sondre Fjellving
Sondre Fjellving
4,700 Points

Thanks for you answer! I didn't know the HTML code was only there for inspection, but now I know for later, thanks! By the way, I made it work now, do you reckon there are any better ways to solve it? I wrote: let navigationLinks = document.querySelectorAll("nav > ul > li > a");

Steven Parker
Steven Parker
231,271 Points
Steven Parker
Steven Parker
231,271 Points

You don't have to be so specific. A more direct translation of "links in a nav element" would simply be "nav a".

Sondre Fjellving
Sondre Fjellving
4,700 Points
Sondre Fjellving
Sondre Fjellving
4,700 Points

Haha, I make it harder than it is.. Thanks for all of the help! Have a good day Steven! :)