Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

Erick Vazquez
Erick Vazquez
2,639 Points
Posted by Erick Vazquez
Erick Vazquez
2,639 Points

Is it a bad idea to create a function that creates these objects for me?

For example for this code challenge I am using this createPetObject function that I created to well... create pet objects. Is this bad practice? Am I setting myself up for failure?

/*
  Create an array of 'pet' objects.
  Each object should have the following properties: 
  name, type, breed, age, and photo
*/
function createPetObject(name, type, breed, age, photo) {
  let pet = {};
  pet.name = name;
  pet.type = type;
  pet.breed = breed;
  pet.age = age;
  pet.photo = photo;
  return pet;
}

let pets = [
  createPetObject('fido', 'dog', 'aussie', 3, 'aussie.jpg'),
  createPetObject('andy', 'dog', 'dachsund', 8, 'dachsund.jpg'),
  createPetObject('sammy', 'dog', 'golden retriever', 11, 'golden.jpg')
]

1 Answer

Travis Alstrand
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Travis Alstrand
Treehouse Project Reviewer
Travis Alstrand
.a{fill-rule:evenodd;}techdegree seal-36
Travis Alstrand
Treehouse Project Reviewer

I'm not sure of which Code Challenge you're on specifically so I'm not sure if this approach will allow you to pass the challenge as they can be very specific in what they want you to write out. I'm also not sure of which course you're in but, I guess it depends on the context of the project.

In general, the fact that you thought to create a function to perform what would be repeated code is the perfect frame of mind to have! That's exactly the 'function' of a function. 😅

It also sounds like a good case for creating a class, but like I said, I'm not sure where you're at in your learning. Nice stuff!