Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Letter Game App Letter Game Refinement

Peter Falcone
PLUS
Peter Falcone
Courses Plus Student 1,108 Points
Posted by Peter Falcone
Peter Falcone
Courses Plus Student 1,108 Points

letter game aaaaaaalllllllllmost working, but not quite

when I play the game, it will not display the wrong guesses, and instead of placing the correct guesses in the spaces, it instead places them where the wrong ones are intended to show up.

import random import os import sys

make list of words

words = [ 'fool', 'magus', 'priestess', 'empress', 'emperor', 'hierophant', 'lovers', 'chariot', 'adjustment', 'hermit', 'fortune', 'lust', 'hanged man', 'death', 'art', 'devil', 'tower', 'star', 'moon', 'sun', 'aeon', 'universe', ]

def clear(): if os.name == 'nt': os.system('cls') else: os.system('clear')

def draw(good_guesses, bad_guesses, secret_word): clear()

print('Strikes: {}/7'.format(len(bad_guesses)))
print('')

for letter in bad_guesses:
    print(letter, end=' ')
print('\n\n')

for letter in secret_word:
    if letter in good_guesses:
        print(letter, end='')
    else:
        print('_', end='')

print('')

def get_guess(bad_guesses, good_guesses): while True: guess = input("Guess a letter: ").lower()

    if len(guess) != 1:
        print("You can only guess a single letter!")
    elif guess in bad_guesses or guess in good_guesses:
        print("You've already used that one!")
    elif not guess.isalpha():
        print("You can only use letters!") 
    else:
        return guess

def play(done): clear() secret_word = random.choice(words) bad_guesses = [] good_guesses = []

while True:
    draw(bad_guesses, good_guesses, secret_word)
    guess = get_guess(bad_guesses, good_guesses)

    if guess in secret_word:
        good_guesses.append(guess)
        found = True
        for letter in secret_word:
            if letter not in good_guesses:
                found = False
        if found:
            print("Well done!")
            print("Your given word was {}!".format(secret_word))
            done = True
    else:
        bad_guesses.append(guess)
        if len(bad_guesses) == 7:
            draw(bad_guesses, good_guesses, secret_word)
            print("You have lost and appear to be misaligned.")
            print("{} was your given word.".format(secret_word))
            done = True

    if done:
        play_again = input("Wilt thou to play again? Y/N ").upper()
        if play_again != 'N':
            return play(done=False)
        else:
            sys.exit()

def welcome(): start = input("Press Enter/Return to begin or Q to quit ").upper if start == 'Q': print("Until we meet again...") sys.exit() else: return True

print("Welcome to the Major Arcana Guessing Game!")

done = False

while True: clear() welcome() play(done)

Steven Parker
Steven Parker
231,269 Points
Steven Parker
Steven Parker
231,269 Points

:point_right: Try formatting your code so the spacing shows up (in Python, indentation is everything).

Use the instructions for code formatting in the Markdown Cheatsheet pop-up below the "Add an Answer" area. :arrow_heading_down:

1 Answer

Steven Parker
Steven Parker
231,269 Points
Steven Parker
Steven Parker
231,269 Points

It looks like you have an argument mismatch.

When you define draw, you list its arguments like this:

def draw(good_guesses, bad_guesses, secret_word):

But when you call it, you pass it arguments in a different order:

        draw(bad_guesses, good_guesses, secret_word)

You probably want to exchange those first two arguments.