My attempt - did I brainfart too much?

Question

Okay, so I tried to do this challenge without looking up the answer. Quite fun, but also though as I'm still shaky in the language of JavaScript.. well, any 'real' programming language. So please tell me if this is totally illogical:

var questions = [
  ['Hvilket band har lavet sangen Loud Pipes?', 'RATATAT'],
  ['Hvilken fransk duo bærer elektroniske masker?', 'DAFT PUNK'],
  ['Følgende band har bl.a. udgivet sangene "New Slang" & "Simple Song"', 'THE SHINS']
];
var answersCorrect = [];
var answersIncorrect = [];
var questionsCorrect = [];
var questionsIncorrect = [];

function result (questionsX, answersX){
  for (var y = 0; y < questionsX.length; y++) {
  var out = document.write('<b>' + questionsX[y] + '</b>' + ' ' + answersX[y].toUpperCase() + '<br>');
  }
  return out;
}

for (var i = 0; i < questions.length; i++) {
  var answer = prompt(questions[i][0]);
  if (answer.toUpperCase() === questions[i][1]) {
    answersCorrect.push(answer);
    questionsCorrect.push(questions[i][0]);
    console.log('Question answered correctly');
  } else {
    answersIncorrect.push(answer);
    questionsIncorrect.push(questions[i][0]);
    console.log('Question answered incorrectly'); 
  }
}

document.write('<h2>Rigtige svar: ' + answersCorrect.length + '</h2>' + '<br>');
  result(questionsCorrect, answersCorrect);
document.write('<h2>Forkerte svar: ' + answersIncorrect.length + '</h2>' + '<br>');
  result(questionsIncorrect, answersIncorrect);

Answer 1 · 2015-09-29T03:09:17Z

September 29, 2015 3:09am

So, a couple of things:

First, you don't really need separate arrays for the correctly answered questions and answers, just leave them grouped together in their own inner array and access the index you need when you want either the question or the answer from it.

Second, you don't need to use both document.write *and * return in the function, you should do one or the other. Personally I think you're better off constructing the result HTML and just returning it as a string, so you can use it for things other than document.write (like updating an element's innerHTML property, for example).

Then you would call your function within the document.write call (the below assumes you changed the function to only use one input array argument):

document.write(result(correct));

Answer 2 · 2015-09-29T00:55:37Z

September 29, 2015 12:55am

For your questions I would have made them with keys, like

questions = [ 
{'question' : 'Hvilket band har lavet sangen Loud Pipes?',
'answer' : 'RATATAT'}
]

It would make it easier to work with later, so you could just do question.question and question.answer instead of looking through the array for it. Also means you could refactor your code later (say you add a difficulty, category or something of that nature) without worrying about changing the array index.

I'm curious though why are there "answers correct" and "questions correct" arrays?

Welcome to the Treehouse Community

Looking to learn something new?

Michael Lauridsen

Michael Lauridsen

My attempt - did I brainfart too much?

2 Answers

Iain Simmons

Iain Simmons

Michael Lauridsen

Michael Lauridsen

James Bradd

James Bradd

Iain Simmons

Iain Simmons

Michael Lauridsen

Michael Lauridsen