Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

iOS

Posted by isaac brakha
isaac brakha
6,781 Points

Possible to Shorten this line of code?

Hello, i have a feeling the following line of code, could be written more compactly.

let income = ["months":["enero":[ganancia, perdida, resultado],"febrero":[ganancia, perdida, resultado],"marzo":[ganancia, perdida, resultado],"abril":[ganancia, perdida, resultado],"mayo":[ganancia, perdida, resultado],"junio":[ganancia, perdida, resultado],"julio":[ganancia, perdida, resultado],"agosto":[ganancia, perdida, resultado],"septiembre":[ganancia, perdida, resultado],"octubre":[ganancia, perdida, resultado],"noviembre":[ganancia, perdida, resultado],"diciembre":[ganancia, perdida, resultado]]]

thanks in advance

1 Answer

jcorum
jcorum
71,830 Points
jcorum
jcorum
71,830 Points

Yes, and the DRY principle would require it to be shortened. Here's one way:

let ganancia = "x"
let perdida = "y"
let resultado = "z"

let gpr = [ganancia, perdida,resultado]

let income = ["months": ["enero": gpr, "febrero": gpr, "marzo": gpr, "abril": gpr, "mayo": gpr, "junio": gpr, "julio": gpr, "agosto": gpr, "septiembre": gpr, "octubre": gpr, "noviembre": gpr, "diciembre":gpr]]

I had to create the three constants in order for the rest to compile. And, of course, you will have your own values for them. But with this version, if you ever decided to change gpr, you now have to make the change in only one place, rather than in 12 places.

isaac brakha
isaac brakha
6,781 Points

Perfect. I understand, Thank you very much,