Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

Posted by ygh5254e69hy5h545uj56592yh5j94595682hy95
ygh5254e69hy5h545uj56592yh5j94595682hy95
7,934 Points

(RSVP App) Test my first application

  • I just finished polishing the RSVP App from the JavaScript course that I did.
  • I believe I fixed almost all issues, but would love to have other people go and test the functionality of the application.

https://kleosdc.github.io/

  • The application allows the user to:

  1. Add guests to the list

  2. Remove guests from the list

  3. Filter by confirmed guests

  4. Rename guest name

  5. Add note to the guest

  • The application should not allow the user to:

  1. Add duplicate name at any point of time

  2. Show unconfirmed guests when the 'Hide those who haven't responded' checkbox is checked

  3. Rename name of guest when in 'Edit' mode.

Any tips on how to improve the application and feature advice is greatly appreciated! Thanks.

2 Answers

Michael Hulet
Michael Hulet
47,913 Points
Michael Hulet
Michael Hulet
47,913 Points

Whoa, this looks really good! My only 2 notes are:

  1. You use a div with a class of main, but HTML5 provides a whole element called main. For the sake of semantics, it's probably better to use that instead
  2. In your CSS, you use the universal selector (*), which is generally considered to be slow. It may not be obvious now, but if you're ever working on a really big webpage with lots of elements, it'll definitely slow down your rendering time. It might be better to switch out that selector for html or body instead

Other than that, this looks really high-quality, and something to be proud of. Great job!

ygh5254e69hy5h545uj56592yh5j94595682hy95
ygh5254e69hy5h545uj56592yh5j94595682hy95
7,934 Points

Thank you so much for your feedback!

Zimri Leijen
Zimri Leijen
11,835 Points
Zimri Leijen
Zimri Leijen
11,835 Points

Good job, seems to work fine.

I'd change the alert to something else though.

Maybe for example changing the appearance of the input field, and showing a message under it. (Perhaps make the input field background light red, with a red border, and then an error message underneath).

One thing I did notice is that it doesn't check for capitalization, so 'John' and 'john' are not considered the same name.

Maybe you can make it so that every first letter of every name is capitalized. Keep in mind that that should also capitalize the name name 'John Doe' correctly, for example.

ygh5254e69hy5h545uj56592yh5j94595682hy95
ygh5254e69hy5h545uj56592yh5j94595682hy95
7,934 Points

Thank you so much for your feedback!