Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Sean Poore
Sean Poore
5,365 Points

Stuck on Getter and Setter Challange

Hello! My answer is 

    get major() {
      return this._major;
    }

    set major(major) {
      this._major = major;
      if (student.level == 'Junior' || student.level == 'Senior') {
        this._major = major;
      } else {
        this._major = 'None';
      }
    }

And it's not working, does anybody know why this answer isn't good?

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

    get major() {
      return this._major;
    }

    set major(major) {
      this._major = major;
      if (student.level == 'Junior' || student.level == 'Senior') {
        this._major = major;
      } else {
        this._major = 'None';
      }
    }
}

var student = new Student(3.9, 60);

1 Answer

Steven Parker
Steven Parker
231,269 Points
Steven Parker
Steven Parker
231,269 Points

In the object methods, references to the current object should use the keyword "this" instead of the object name.

Also, while your getter code looks fine, it's not part of the challenge. The instructions only ask for the setter.