Syntax Error on my values within a function Javascipt

hey finn, actually the solution is pretty simple and when you read it you'll say "damn, I know that already" :D

now you're using variables (placeholders) in the max-function. so when you call that function you need to give them something to deal with, otherwise the function has nothing to do. therefore you need to pass numbers when you call it, like this:

alert(max(2,3));

the numbers 2 and 3 can be anything you want. these are simply the values the variables num1 and num2 take to work with. hope that helps and have a nice day ;)

Finn,

The problem here is actually how you're passing values into the function to stand in as arguments. You are currently assigning values in the parenthesis, as you would if you were CALLING the function; we don't want to do that. We need to give the function arguments so that the function could be reused elsewhere in our code.

The instructions state "Create a function named max() which accepts two numbers as arguments." Here, you need to pass in two variable names as arguments for your function; you're not intended to be passing actual numbers. Recall that functions are built to be reusable pieces of code, so you don't want to assign the values of 10 and 5 yet, as you have done, or this function is wasted (and will not pass the challenge). Think about what the goal of the function is, and then create some appropriately named variables to stand in as arguments. Since this function's job is going to be to compare two numbers, let's just call the arguments "num1" and "num2" for brevity and simplicity.

function max(num1, num2) {
}

Make sure you create your conditional statement inside the function, too, before attempting to pass the challenge.

Hope this helps to make it a bit more clear!

Erik

Thanks so much both,

Not using an actually value was what was confusing me and can now understand after your explanations why the arguments must be a variable.

In the second part of the objective it then asks me to call the function within a dialogue box:

function max(num1, num2) { if (num1 > num2){ return num1 } else { return num2 } } alert( max() );

This posts an error saying "Did you pass 2 numbers to the max() function."

Does this mean i need to use a method to change the variables into values or something simpler than that?

Appreciate both your help this far, thanks again. This question has really puzzled me for some reason. Cheers, Finn