Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects (Retired) Delivering the MVP Wrapping up

trina joy
trina joy
6,525 Points

User class - adding constructor and getters.

What am i doing wrong?

ForumPost.java
public class ForumPost {
  private User mAuthor;
  private String mTitle;
  private String mDescription;

  public User getAuthor() {
    return mAuthor;
  }

  public String getTitle() {
    return mTitle;
  }

  // TODO: We need to expose the description
}
User.java
public class User {

  private String mFirstName;
  private String mLastName;

  public User(String firstName, String lastName) {
    mFirstName = firstName;
    mLastName = lastName;

  }
    public String getFirstName(String firstName){
      return firstName;        
    }

    public String getLastName(String lastName){
      return lastName;      
    }


}
Forum.java
public class Forum {
  private String mTopic;

  public Forum (String topic){
   mTopic = topic; 
  }

  public String getTopic() {
      return mTopic;
  }

  public void addPost(ForumPost post) {
      /* When all is ready uncomment this...
      System.out.printf("New post from %s %s about %s.\n",
                         post.getAuthor().getFirstName(),
                         post.getAuthor().getLastName(),
                         post.getTitle());
      */
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    System.out.println("Starting forum example...");
    if (args.length < 2) {
       System.out.println("first and last name are required. eg:  java Example Craig Dennis");
    }
    // Forum forum = new Forum("Java");
    // Take the first two elements passed args
    // User author = new User();
    // Add the author, title and description
    // ForumPost post = new ForumPost();
    // forum.addPost(post);
  }
}

1 Answer

Kevin Faust
Kevin Faust
15,353 Points

Hey Trina,

The problem lies in your User.java file.

What getters and setters do is their ability to grab the value and set the value of private variables. What your getters are doing at the moment is taking in a string and then spitting that same string back out. What we want to is for the getter to spit out the value of our private variable in the top. How do we do this? Simple:

public String getFirstName() {
      return mFirstName;        
    }

    public String getLastName() {
      return mLastName;      
    }

As you can see, getters never have paramters. You call them and they they will return the value of your m private variable.

If this helped, dont forget to mark as best answer so others with the same question can see

Happy coding and all the best,

Kevin