Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Posted by Thomas Katalenas
Thomas Katalenas
11,033 Points

what did I do?

?

script.js 
function max(one, two) {
    if one > two {
      return one
    } else {
      return two
}

3 Answers

Julian Gutierrez
Julian Gutierrez
19,201 Points
Julian Gutierrez
Julian Gutierrez
19,201 Points

A few things, your if statement needs parenthesis wrapping your condition, semi-colons are needed after your return statements. Also your function needs a closing bracket, currently only the else if is closed.

Thomas Katalenas
Thomas Katalenas
11,033 Points
Thomas Katalenas
Thomas Katalenas
11,033 Points

what about this

function max(one, two) {
  if one > two{
    return one;
  } else {
    return two;
  }
};
Julian Gutierrez
Julian Gutierrez
19,201 Points
Julian Gutierrez
Julian Gutierrez
19,201 Points

Still need the parenthesis around your conditional:

function max(one, two) {
  if (one > two){
    return one;
  } else {
    return two;
  }
};
Thomas Katalenas
Thomas Katalenas
11,033 Points
Thomas Katalenas
Thomas Katalenas
11,033 Points

that didn't work and neither did this

function max(one, two) {
  if one > two { 
    return one;
  }else if two > one {
    return two;
  } else {
    return False;
  }
}