Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Posted by Melvin Miller
Melvin Miller
4,242 Points

Why doesn't my code work for JavaScript Basics ?

function max(35, 45) { if (max >= 45) { return 45; } else { return 35; } }

script.js 
function max(35, 45) {
  if (max >= 45) {
return 45;
  } else {
   return 35;
  }
}
Ashish Mehra
Ashish Mehra
Courses Plus Student 589 Points

hey Melvin ! In if condition you are comparing function with second number which cause error 

var a=35;
var b=45;
function max(a,b) {
  if (a>b) {
return a;
  } else {
   return b;
  }
}

1 Answer

Evan Demaris
Evan Demaris
64,262 Points
Evan Demaris
Evan Demaris
64,262 Points

Hi Melvin,

Your function has arguments already setup for its parameters, and is trying to call itself within the closure.

The following code would pass the first task of the Challenge;

function max(first_number, second_number) {
  if (first_number >= second_number) {
return first_number;
  } else {
   return second_number;
  }
}

The second task of the Challenge can be passed by calling the function with arguments provided for the first_number and second_number parameters;

alert(max(35, 45));

Please let me know if you have any questions about how or why that works!